Checkstyle Results
The following document contains the results of Checkstyle 6.18 with /Users/rgoers/projects/apache/logging/log4j/log4j-2.13.3/log4j-1.2-api/../checkstyle.xml ruleset.
Summary
| Files |
|
|
|
|---|---|---|---|
| 101 | 0 | 0 | 321 |
Files
Details
org/apache/log4j/AppenderSkeleton.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 35 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 37 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
|
|
whitespace | WhitespaceAround | 'if' is not followed by whitespace. | 60 |
|
|
coding | SuperFinalize | Method 'finalize' should call 'super.finalize'. | 76 |
|
|
javadoc | JavadocType | Missing a Javadoc comment. | 146 |
org/apache/log4j/Category.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'org.apache.logging.log4j.message.LocalizedMessage' import. | 35 |
|
|
naming | ConstantName | Name 'isCoreAvailable' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$|^capabilities$|^log$'. | 54 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 72 |
|
|
coding | HiddenField | 'bundle' hides a field. | 411 |
|
|
javadoc | JavadocType | Missing a Javadoc comment. | 516 |
|
|
whitespace | WhitespaceAround | 'for' is not followed by whitespace. | 550 |
|
|
whitespace | WhitespaceAround | 'if' is not followed by whitespace. | 565 |
org/apache/log4j/ConsoleAppender.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
blocks | LeftCurly | '{' at column 1 should be on the previous line. | 25 |
|
|
blocks | LeftCurly | '{' at column 3 should be on the previous line. | 32 |
|
|
blocks | LeftCurly | '{' at column 3 should be on the previous line. | 40 |
|
|
blocks | LeftCurly | '{' at column 3 should be on the previous line. | 49 |
org/apache/log4j/Layout.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 27 |
org/apache/log4j/LogManager.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
naming | ConstantName | Name 'isLog4jCore' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$|^capabilities$|^log$'. | 71 |
org/apache/log4j/Priority.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
design | VisibilityModifier | Variable 'level' must be private and have accessor methods. | 96 |
|
|
design | VisibilityModifier | Variable 'levelStr' must be private and have accessor methods. | 97 |
|
|
design | VisibilityModifier | Variable 'syslogEquivalent' must be private and have accessor methods. | 98 |
org/apache/log4j/SimpleLayout.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
blocks | LeftCurly | '{' at column 1 should be on the previous line. | 26 |
|
|
blocks | LeftCurly | '{' at column 3 should be on the previous line. | 33 |
|
|
blocks | LeftCurly | '{' at column 3 should be on the previous line. | 42 |
org/apache/log4j/WriterAppender.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
|
|
imports | ImportOrder | Wrong order for 'java.io.IOException' import. | 25 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'layout'. | 80 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'os'. | 80 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'layout'. | 91 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'writer'. | 91 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'event'. | 142 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'eh'. | 266 |
|
|
javadoc | JavadocMethod | Expected an @return tag. | 332 |
org/apache/log4j/bridge/AppenderAdapter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocPackage | Missing package-info.java file. | |
|
|
javadoc | JavadocType | Missing a Javadoc comment. | 66 |
org/apache/log4j/bridge/AppenderWrapper.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | UnusedImports | Unused import - org.apache.log4j.spi.AppenderAttachable. | 22 |
|
|
imports | ImportOrder | Wrong order for 'java.util.ArrayList' import. | 30 |
|
|
imports | UnusedImports | Unused import - java.util.ArrayList. | 30 |
|
|
imports | UnusedImports | Unused import - java.util.Enumeration. | 31 |
|
|
imports | UnusedImports | Unused import - java.util.List. | 32 |
|
|
whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 98 |
org/apache/log4j/bridge/LayoutAdapter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.HashMap' import. | 23 |
org/apache/log4j/bridge/LayoutWrapper.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
whitespace | WhitespaceAfter | 'typecast' is not followed by whitespace. | 37 |
org/apache/log4j/bridge/LogEventAdapter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.lang.reflect.Method' import. | 30 |
org/apache/log4j/bridge/LogEventWrapper.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.HashMap' import. | 37 |
|
|
coding | HiddenField | 'thread' hides a field. | 127 |
|
|
coding | HiddenField | 'thread' hides a field. | 133 |
|
|
coding | HiddenField | 'thread' hides a field. | 139 |
|
|
javadoc | JavadocType | Missing a Javadoc comment. | 188 |
|
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 208 |
|
|
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 213 |
org/apache/log4j/bridge/RewritePolicyAdapter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocMethod | Expected @param tag for 'policy'. | 34 |
org/apache/log4j/bridge/RewritePolicyWrapper.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'org.apache.log4j.rewrite.RewritePolicy' import. | 21 |
org/apache/log4j/builders/AbstractBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocPackage | Missing package-info.java file. | |
|
|
imports | ImportOrder | Wrong order for 'java.util.ArrayList' import. | 29 |
|
|
naming | StaticVariableName | Name 'LOGGER' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 38 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 39 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 39 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 40 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 41 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 41 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 42 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 42 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 43 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 43 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 44 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 44 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 45 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 45 |
org/apache/log4j/builders/BuilderManager.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.lang.reflect.Constructor' import. | 36 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 46 |
|
|
coding | DeclarationOrder | Static variable definition in wrong order. | 49 |
|
|
whitespace | NoWhitespaceAfter | '{' is followed by whitespace. | 49 |
|
|
sizes | LineLength | Line is longer than 120 characters (found 134). | 145 |
|
|
sizes | LineLength | Line is longer than 120 characters (found 122). | 169 |
org/apache/log4j/builders/Holder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocType | Type Javadoc comment is missing an @param <T> tag. | 22 |
|
|
coding | HiddenField | 'value' hides a field. | 32 |
org/apache/log4j/builders/appender/AppenderBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 24 |
org/apache/log4j/builders/appender/AsyncAppenderBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocPackage | Missing package-info.java file. | |
|
|
imports | UnusedImports | Unused import - org.apache.log4j.bridge.AppenderAdapter. | 20 |
|
|
imports | ImportOrder | Wrong order for 'java.util.ArrayList' import. | 36 |
|
|
imports | UnusedImports | Unused import - org.apache.log4j.xml.XmlConfiguration.REF_ATTR. | 43 |
|
|
imports | ImportOrder | Wrong order for 'org.apache.log4j.config.Log4j1Configuration.APPENDER_REF_TAG' import. | 46 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 50 |
|
|
coding | MagicNumber | '1024' is a magic number. | 74 |
|
|
coding | MagicNumber | '1024' is a magic number. | 137 |
org/apache/log4j/builders/appender/ConsoleAppenderBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.ArrayList' import. | 36 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 49 |
|
|
sizes | LineLength | Line is longer than 120 characters (found 125). | 97 |
org/apache/log4j/builders/appender/DailyRollingFileAppenderBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | UnusedImports | Unused import - org.apache.log4j.bridge.FilterAdapter. | 22 |
|
|
imports | UnusedImports | Unused import - org.apache.log4j.bridge.FilterWrapper. | 23 |
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 43 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 55 |
|
|
coding | MagicNumber | '8192' is a magic number. | 81 |
|
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 173 |
org/apache/log4j/builders/appender/FileAppenderBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | UnusedImports | Unused import - org.apache.log4j.bridge.FilterAdapter. | 22 |
|
|
imports | UnusedImports | Unused import - org.apache.log4j.bridge.FilterWrapper. | 23 |
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 39 |
|
|
imports | ImportOrder | Wrong order for 'org.apache.log4j.xml.XmlConfiguration.NAME_ATTR' import. | 47 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 50 |
|
|
coding | MagicNumber | '8192' is a magic number. | 75 |
org/apache/log4j/builders/appender/NullAppenderBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 29 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 33 |
org/apache/log4j/builders/appender/RewriteAppenderBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.ArrayList' import. | 38 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 52 |
org/apache/log4j/builders/appender/RollingFileAppenderBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | UnusedImports | Unused import - org.apache.log4j.bridge.FilterAdapter. | 22 |
|
|
imports | UnusedImports | Unused import - org.apache.log4j.bridge.FilterWrapper. | 23 |
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 45 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 57 |
|
|
coding | MagicNumber | '8192' is a magic number. | 81 |
|
|
whitespace | WhitespaceAround | '+' is not followed by whitespace. | 194 |
org/apache/log4j/builders/appender/SyslogAppenderBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 39 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 50 |
|
|
naming | StaticVariableName | Name 'SYSLOG_PORT' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 59 |
|
|
coding | MagicNumber | '512' is a magic number. | 59 |
org/apache/log4j/builders/filter/DenyAllFilterBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 31 |
org/apache/log4j/builders/filter/LevelMatchFilterBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 33 |
org/apache/log4j/builders/filter/LevelRangeFilterBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocPackage | Missing package-info.java file. | |
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 34 |
org/apache/log4j/builders/filter/StringMatchFilterBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 32 |
|
|
imports | UnusedImports | Unused import - java.util.Properties. | 32 |
org/apache/log4j/builders/layout/HtmlLayoutBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 32 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 37 |
org/apache/log4j/builders/layout/PatternLayoutBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 34 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 39 |
|
|
whitespace | NoWhitespaceAfter | '++' is followed by whitespace. | 61 |
org/apache/log4j/builders/layout/SimpleLayoutBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocPackage | Missing package-info.java file. | |
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 29 |
|
|
imports | UnusedImports | Unused import - java.util.Properties. | 29 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 33 |
org/apache/log4j/builders/layout/TTCCLayoutBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 33 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 38 |
org/apache/log4j/builders/layout/XmlLayoutBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 32 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 38 |
org/apache/log4j/builders/rewrite/RewritePolicyBuilder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocPackage | Missing package-info.java file. |
org/apache/log4j/config/InputStreamWrapper.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocType | Missing a Javadoc comment. | 22 |
|
|
modifier | RedundantModifier | Redundant 'public' modifier. | 27 |
org/apache/log4j/config/Log4j1Configuration.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | UnusedImports | Unused import - org.apache.logging.log4j.core.config.Node. | 24 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 34 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 36 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 38 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 40 |
org/apache/log4j/config/Log4j1ConfigurationConverter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
sizes | LineLength | Line is longer than 120 characters (found 126). | 50 |
|
|
javadoc | JavadocType | Missing a Javadoc comment. | 55 |
|
|
coding | DeclarationOrder | Instance variable definition in wrong order. | 141 |
|
|
coding | DeclarationOrder | Constructor definition in wrong order. | 143 |
|
|
sizes | LineLength | Line is longer than 120 characters (found 127). | 179 |
org/apache/log4j/config/Log4j1ConfigurationParser.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
sizes | LineLength | Line is longer than 120 characters (found 139). | 55 |
|
|
sizes | LineLength | Line is longer than 120 characters (found 139). | 56 |
|
|
sizes | LineLength | Line is longer than 120 characters (found 133). | 57 |
|
|
sizes | LineLength | Line is longer than 120 characters (found 140). | 58 |
|
|
sizes | LineLength | Line is longer than 120 characters (found 124). | 59 |
org/apache/log4j/config/PropertiesConfiguration.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | UnusedImports | Unused import - org.apache.log4j.LogManager. | 21 |
|
|
imports | UnusedImports | Unused import - org.apache.log4j.builders.BuilderManager. | 25 |
|
|
imports | ImportOrder | Wrong order for 'java.io.InputStream' import. | 35 |
|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 58 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 61 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 62 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 62 |
|
|
whitespace | WhitespaceAround | '=' is not preceded with whitespace. | 62 |
|
|
whitespace | WhitespaceAround | '=' is not followed by whitespace. | 62 |
|
|
javadoc | JavadocType | Missing a Javadoc comment. | 578 |
|
|
coding | MultipleVariableDeclarations | Each variable declaration must be in its own statement. | 579 |
|
|
design | VisibilityModifier | Variable 'key' must be private and have accessor methods. | 579 |
|
|
design | VisibilityModifier | Variable 'value' must be private and have accessor methods. | 579 |
org/apache/log4j/config/PropertiesConfigurationFactory.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
|
|
sizes | LineLength | Line is longer than 120 characters (found 122). | 48 |
org/apache/log4j/config/PropertySetter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
|
|
imports | ImportOrder | Wrong order for 'java.beans.BeanInfo' import. | 31 |
|
|
naming | StaticVariableName | Name 'LOGGER' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 59 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 60 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 61 |
org/apache/log4j/helpers/AppenderAttachableImpl.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.Collections' import. | 23 |
org/apache/log4j/helpers/OptionConverter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
|
|
imports | ImportOrder | Wrong order for 'java.io.InterruptedIOException' import. | 25 |
|
|
design | FinalClass | Class OptionConverter should be declared as final. | 32 |
|
|
naming | StaticVariableName | Name 'DELIM_START' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 34 |
|
|
design | VisibilityModifier | Variable 'DELIM_START' must be private and have accessor methods. | 34 |
|
|
naming | StaticVariableName | Name 'DELIM_STOP' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 35 |
|
|
design | VisibilityModifier | Variable 'DELIM_STOP' must be private and have accessor methods. | 35 |
|
|
naming | StaticVariableName | Name 'DELIM_START_LEN' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 36 |
|
|
design | VisibilityModifier | Variable 'DELIM_START_LEN' must be private and have accessor methods. | 36 |
|
|
naming | StaticVariableName | Name 'DELIM_STOP_LEN' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 37 |
|
|
design | VisibilityModifier | Variable 'DELIM_STOP_LEN' must be private and have accessor methods. | 37 |
|
|
naming | ConstantName | Name 'charMap' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$|^capabilities$|^log$'. | 39 |
|
|
regexp | RegexpSingleline | Line has trailing spaces. | 47 |
|
|
coding | MultipleVariableDeclarations | Each variable declaration must be in its own statement. | 300 |
|
|
javadoc | JavadocType | Missing a Javadoc comment. | 416 |
|
|
design | VisibilityModifier | Variable 'key' must be private and have accessor methods. | 417 |
|
|
design | VisibilityModifier | Variable 'replacement' must be private and have accessor methods. | 418 |
|
|
modifier | RedundantModifier | Redundant 'public' modifier. | 420 |
org/apache/log4j/helpers/QuietWriter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
|
|
imports | ImportOrder | Wrong order for 'java.io.FilterWriter' import. | 23 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 33 |
org/apache/log4j/layout/Log4j1XmlLayout.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocPackage | Missing package-info.java file. | |
|
|
coding | DeclarationOrder | Constructor definition in wrong order. | 58 |
|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 112 |
org/apache/log4j/legacy/core/CategoryUtil.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocPackage | Missing package-info.java file. |
org/apache/log4j/or/ObjectRenderer.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocPackage | Missing package-info.java file. | |
|
|
javadoc | JavadocMethod | Expected an @return tag. | 26 |
|
|
whitespace | FileTabCharacter | File contains tab characters (this is the first instance). | 26 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'o'. | 26 |
org/apache/log4j/or/ThreadGroupRenderer.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
whitespace | WhitespaceAround | 'if' is not followed by whitespace. | 27 |
|
|
whitespace | WhitespaceAround | 'catch' is not followed by whitespace. | 52 |
org/apache/log4j/or/jms/MessageRenderer.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocPackage | Missing package-info.java file. | |
|
|
imports | ImportOrder | Wrong order for 'javax.jms.Message' import. | 23 |
|
|
imports | ImportOrder | Wrong order for 'javax.jms.JMSException' import. | 24 |
|
|
imports | ImportOrder | Wrong order for 'javax.jms.DeliveryMode' import. | 25 |
|
|
javadoc | JavadocStyle | First sentence should end with a period. | 27 |
|
|
javadoc | JavadocMethod | Expected an @return tag. | 36 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'obj'. | 37 |
|
|
whitespace | WhitespaceAround | 'switch' is not followed by whitespace. | 43 |
|
|
whitespace | WhitespaceAround | 'catch' is not followed by whitespace. | 79 |
org/apache/log4j/pattern/Log4j1MdcPatternConverter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
sizes | LineLength | Line is longer than 120 characters (found 126). | 82 |
|
|
coding | DeclarationOrder | Static variable definition in wrong order. | 82 |
|
|
naming | StaticVariableName | Name 'APPEND_EACH' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 82 |
org/apache/log4j/pattern/Log4j1NdcPatternConverter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocPackage | Missing package-info.java file. | |
|
|
imports | ImportOrder | Wrong order for 'java.util.List' import. | 26 |
org/apache/log4j/rewrite/MapRewritePolicy.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
|
|
imports | ImportOrder | Wrong order for 'java.util.HashMap' import. | 30 |
org/apache/log4j/rewrite/PropertyRewritePolicy.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocPackage | Missing package-info.java file. | |
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
|
|
imports | ImportOrder | Wrong order for 'java.util.Collections' import. | 28 |
org/apache/log4j/rewrite/RewritePolicy.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
org/apache/log4j/spi/AppenderAttachable.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
|
|
imports | ImportOrder | Wrong order for 'java.util.Enumeration' import. | 22 |
org/apache/log4j/spi/Configurator.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
|
modifier | RedundantModifier | Redundant 'public' modifier. | 29 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
|
modifier | RedundantModifier | Redundant 'public' modifier. | 31 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'loggerContext'. | 44 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'loggerContext'. | 54 |
org/apache/log4j/spi/ErrorCode.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
|
|
design | InterfaceIsType | interfaces should describe a type and hence have methods. | 24 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 26 |
|
|
modifier | RedundantModifier | Redundant 'public' modifier. | 26 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 27 |
|
|
modifier | RedundantModifier | Redundant 'public' modifier. | 27 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
|
|
modifier | RedundantModifier | Redundant 'public' modifier. | 28 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 29 |
|
|
modifier | RedundantModifier | Redundant 'public' modifier. | 29 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 30 |
|
|
modifier | RedundantModifier | Redundant 'public' modifier. | 30 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 31 |
|
|
modifier | RedundantModifier | Redundant 'public' modifier. | 31 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 32 |
|
|
modifier | RedundantModifier | Redundant 'public' modifier. | 32 |
org/apache/log4j/spi/Filter.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
whitespace | WhitespaceAround | 'catch' is not followed by whitespace. | 32 |
|
|
coding | DeclarationOrder | Static variable definition in wrong order. | 42 |
|
|
coding | DeclarationOrder | Static variable definition in wrong order. | 48 |
|
|
coding | DeclarationOrder | Static variable definition in wrong order. | 54 |
|
|
coding | DeclarationOrder | Instance variable definition in wrong order. | 61 |
|
|
design | VisibilityModifier | Variable 'next' must be private and have accessor methods. | 62 |
org/apache/log4j/spi/LocationInfo.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 28 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 28 |
|
|
design | VisibilityModifier | Variable 'fullInfo' must be private and have accessor methods. | 28 |
|
|
coding | DeclarationOrder | Static variable definition in wrong order. | 38 |
|
|
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 38 |
|
|
coding | DeclarationOrder | Static variable definition in wrong order. | 40 |
|
|
javadoc | JavadocMethod | Expected an @return tag. | 47 |
|
|
javadoc | JavadocMethod | Expected an @return tag. | 55 |
|
|
javadoc | JavadocMethod | Expected an @return tag. | 63 |
|
|
javadoc | JavadocMethod | Expected an @return tag. | 71 |
org/apache/log4j/spi/LoggingEvent.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'java.util.Map' import. | 23 |
org/apache/log4j/spi/ThrowableInformation.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | UnusedImports | Unused import - org.apache.logging.log4j.core.util.Throwables. | 23 |
org/apache/log4j/xml/Log4jEntityResolver.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
|
|
imports | ImportOrder | Wrong order for 'java.io.ByteArrayInputStream' import. | 25 |
org/apache/log4j/xml/UnrecognizedElementHandler.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
misc | NewlineAtEndOfFile | File does not end with a newline. | |
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
|
|
imports | ImportOrder | Wrong order for 'java.util.Properties' import. | 20 |
org/apache/log4j/xml/XmlConfiguration.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
imports | ImportOrder | Wrong order for 'javax.xml.parsers.DocumentBuilder' import. | 46 |
|
|
imports | ImportOrder | Wrong order for 'java.io.IOException' import. | 49 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 68 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 68 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 69 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 69 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 74 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 74 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 76 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 76 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 80 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 80 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 82 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 82 |
|
|
naming | ConstantName | Name 'dbfKey' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$|^capabilities$|^log$'. | 88 |
|
|
javadoc | JavadocVariable | Missing a Javadoc comment. | 91 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 91 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 95 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 100 |
|
|
coding | HiddenField | 'props' hides a field. | 179 |
|
|
coding | HiddenField | 'props' hides a field. | 202 |
|
|
coding | HiddenField | 'props' hides a field. | 222 |
|
|
coding | HiddenField | 'props' hides a field. | 239 |
|
|
coding | HiddenField | 'props' hides a field. | 260 |
|
|
javadoc | JavadocMethod | Expected an @return tag. | 331 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'appenderRef'. | 331 |
|
|
javadoc | JavadocMethod | Expected an @return tag. | 340 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'appenderElement'. | 340 |
|
|
javadoc | JavadocMethod | Expected an @return tag. | 479 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'filterElement'. | 479 |
|
|
javadoc | JavadocMethod | Expected an @return tag. | 563 |
|
|
javadoc | JavadocMethod | Expected @param tag for 'layoutElement'. | 563 |
|
|
naming | ParameterName | Name 'layout_element' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 573 |
|
|
javadoc | JavadocType | Missing a Javadoc comment. | 747 |
|
|
javadoc | JavadocType | Missing a Javadoc comment. | 751 |
|
|
javadoc | JavadocType | Missing a Javadoc comment. | 772 |
org/apache/log4j/xml/XmlConfigurationFactory.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
|
|
header | Header | Line does not match expected header line of ' * contributor license agreements. See the NOTICE file distributed with'. | 3 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 41 |
|
|
coding | DeclarationOrder | Variable access definition in wrong order. | 46 |
|
|
sizes | LineLength | Line is longer than 120 characters (found 122). | 50 |
